-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: File attachments have no content when exporting room messages as file #30596
Conversation
🦋 Changeset detectedLatest commit: 774b2ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30596 +/- ##
===========================================
- Coverage 51.28% 51.27% -0.02%
===========================================
Files 811 804 -7
Lines 15078 15107 +29
Branches 2754 2768 +14
===========================================
+ Hits 7733 7746 +13
+ Misses 6935 6933 -2
- Partials 410 428 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: feat: add tooltip to badge mentions (#30590) chore: improve `Tag` a11y link (#30636) refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634) fix: Improve FileProxy Handling, set Content-Type (#30427) refactor: `EditRoomInfo` to typescript (#28318) fix: mobile ringing notification missing call id (#30614) fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560) test: More tests for groups kick (#30536) fix: Threads breaking after sending messages too fast (#30622) chore: Remove text decoration from room tag (#30606) i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613) fix: File attachments have no content when exporting room messages as file (#30596) fix: use setImmediate to handle username update (#30500) chore: `AnalyticsReports` visual adequacy (#30617)
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Expected behavior: the attachments should be available inside the assets directory, and all of their content should be visible just as in RC.
Current behavior: all files are created and available in the assets directory, but they have no content (file sizes are all zero).
Further comments
SUP-358